fix(web): preserve user prompt line breaks#804
Open
swear01 wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Findings
- No issues found with confidence >= 80% in the added or modified lines.
Summary
- Review mode: initial
- The change keeps hard-break parsing scoped to user prompt bubbles via
preserveSingleLineBreaks, while assistant/tool markdown paths continue to useMARKDOWN_PLUGINSwithoutremark-breaks. - Residual risk: visual newline rendering is covered mostly through prop/plugin wiring, not a DOM-level assertion of rendered
<br>output.
Testing
- Not run (automation:
bunnot found on PATH in this runner)
HAPI Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #794
Summary
remark-breaksfor user-authored prompt rendering only.Root cause
User bubbles render through the markdown pipeline. Standard Markdown collapses single newlines unless
remark-breaksor explicit hard breaks are used, while queued message previews usewhitespace-pre-wrap.Test plan
git diff --check upstream/main..HEADbun run --cwd web test src/components/AssistantChat/messages/user-bubble.test.tsx src/components/assistant-ui/markdown-text.test.tsbun run --cwd web typecheckbun run --cwd web test.git/info/hapi-local-notes.md: sent a multi-line user prompt and verified the user bubble preserves line breaks.Pre-PR checks