Skip to content

[codex] Fix vertical push fallback state - #993

Open
nexiumbiz-debug wants to merge 1 commit into
tiberiuzuld:masterfrom
nexiumbiz-debug:codex/fix-vertical-push-swap-941
Open

[codex] Fix vertical push fallback state#993
nexiumbiz-debug wants to merge 1 commit into
tiberiuzuld:masterfrom
nexiumbiz-debug:codex/fix-vertical-push-swap-941

Conversation

@nexiumbiz-debug

Copy link
Copy Markdown
Contributor

Summary

  • prevents recursive push fallback from treating the currently dragged item as an empty target cell
  • removes abandoned pushed-item paths from the correct item path during rollback
  • adds a regression test for vertical-only push where dragging the fourth stacked item upward should not swap unrelated first/second items

Fixes #941.

Validation

  • npm run test-lib -- --watch=false
  • npm run build-lib
  • npx eslint projects/angular-gridster2/src/lib/tests/gridsterPush.spec.ts

Note: full npm run lint -- angular-gridster2 still reports existing unrelated lint errors across the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected swap of first/second items when dragging fourth item in vertical push (pushDirections: north/south only)

1 participant