fix(e2e): force patched serialize-javascript@7.0.5 via npm override#28
Merged
Conversation
serialize-javascript <7.0.5 has a high-severity RCE (GHSA-5c6j-r48x-rmvq) and a DoS (GHSA-qj8w-gfj5-8c6v). It is a transitive devDependency: @wdio/mocha-framework@9.28.0 -> mocha@10.8.2 -> serialize-javascript@^6.0.2. Mocha's ^6.0.2 ceiling blocks the patched 7.0.5, and Dependabot's only in-range path would downgrade @wdio/mocha-framework to 6.1.17. Add an npm `overrides` entry pinning serialize-javascript to ^7.0.5, keeping @wdio/mocha-framework at 9.28.0. Safe because: - dev-only (e2e harness, never shipped in the app) - 7.0.0's only breaking change was dropping Node <20; CI runs Node 20+ - mocha's call signature is unchanged in 7.x; the parallel-worker path that uses it isn't even exercised (wdio.conf.js maxInstances: 1) `npm ci` passes and `npm audit` reports 0 vulnerabilities. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesDependency Override
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
timbortnik
added a commit
that referenced
this pull request
Jun 17, 2026
appium@3.5.0 pins form-data@4.0.5 (exact via @appium/support@7.2.3, ^4.0.5 via axios@1.16.1), which is vulnerable to CWE-93 CRLF injection (GHSA, affected >=4.0.0 <4.0.6). Dependabot's only update path would downgrade appium 3.5.0 -> 1.22.3. Force the patched 4.0.6 via an npm override instead — a patch release that only adds CR/LF/quote escaping in the Content-Disposition header, so it's API-compatible. Both consumers (@appium/support, axios) dedupe to 4.0.6; npm audit reports 0 vulnerabilities. Same approach already used for serialize-javascript (#28). Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the Dependabot alert for serialize-javascript in the
/e2etest harness.serialize-javascript<7.0.5 has a high-severity RCE (GHSA-5c6j-r48x-rmvq) and a DoSMocha's
^6.0.2ceiling blocks the patched7.0.5, and Dependabot's only in-rangepath would downgrade
@wdio/mocha-frameworkto 6.1.17 (a major regression).Fix
Add an npm
overridesentry pinningserialize-javascriptto^7.0.5, keeping@wdio/mocha-framework@9.28.0.Why this is safe
/e2eharness; never in the shipped app.buffered-worker-pool.jsto serializeits own options for parallel workers (trusted local input), and
wdio.conf.jsrunsmaxInstances: 1(no parallel workers).Mocha's call signature is unchanged in 7.x.
Verification
npm cipasses (exit 0) — same command CI runs.npm audit→ 0 vulnerabilities.serialize-javascript@7.0.5 overridden,@wdio/mocha-framework@9.28.0retained.Summary by CodeRabbit