Skip to content

tests: add Vulkan vegetation dispatch ordering regression coverage#111

Draft
cursor[bot] wants to merge 1 commit intonext-gen-5from
cursor/missing-test-coverage-3cc1
Draft

tests: add Vulkan vegetation dispatch ordering regression coverage#111
cursor[bot] wants to merge 1 commit intonext-gen-5from
cursor/missing-test-coverage-3cc1

Conversation

@cursor
Copy link
Copy Markdown

@cursor cursor Bot commented Apr 19, 2026

Summary

  • add tests/scripts/test_vk_vegetation_dispatch_order.sh to guard the Vulkan vegetation-wind bugfix path
  • wire the new script into CTest as test_vk_vegetation_dispatch_order in CMakeLists.txt

Risky behavior now covered

  • prevents regressions where vk_vegetation_wind_dispatch() is called too early from vk_begin_frame (before vegetation staging is filled)
  • enforces that dispatch + staging clear happen from RB_EndSurface under the SURF_VEGETATION + PostFX_VegWind_IsEnabled() gated path

Test files added/updated

  • added: tests/scripts/test_vk_vegetation_dispatch_order.sh
  • updated: CMakeLists.txt (CTest registration)

Why this materially reduces regression risk

This coverage protects a real bugfix in a high-blast-radius render flow: vegetation animation compute work previously ran before tessellation data upload and silently no-op’d (vertexCount==0). The test asserts both sides of the contract (presence in RB_EndSurface, absence in vk_begin_frame) so future refactors cannot accidentally reintroduce frame-ordering regressions without failing CI.

Validation

  • tests/scripts/test_vk_vegetation_dispatch_order.sh
  • ctest -R test_vk_vegetation_dispatch_order --output-on-failure (after reconfigure)
Open in Web View Automation 

Co-authored-by: Tim Fox <timfox@outlook.com>
@cursor cursor Bot force-pushed the cursor/missing-test-coverage-3cc1 branch 2 times, most recently from ff3cd0a to d430b8b Compare April 19, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant