tests: add Vulkan vegetation dispatch ordering regression coverage#111
Draft
cursor[bot] wants to merge 1 commit intonext-gen-5from
Draft
tests: add Vulkan vegetation dispatch ordering regression coverage#111cursor[bot] wants to merge 1 commit intonext-gen-5from
cursor[bot] wants to merge 1 commit intonext-gen-5from
Conversation
Co-authored-by: Tim Fox <timfox@outlook.com>
ff3cd0a to
d430b8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/scripts/test_vk_vegetation_dispatch_order.shto guard the Vulkan vegetation-wind bugfix pathtest_vk_vegetation_dispatch_orderinCMakeLists.txtRisky behavior now covered
vk_vegetation_wind_dispatch()is called too early fromvk_begin_frame(before vegetation staging is filled)RB_EndSurfaceunder theSURF_VEGETATION+PostFX_VegWind_IsEnabled()gated pathTest files added/updated
tests/scripts/test_vk_vegetation_dispatch_order.shCMakeLists.txt(CTest registration)Why this materially reduces regression risk
This coverage protects a real bugfix in a high-blast-radius render flow: vegetation animation compute work previously ran before tessellation data upload and silently no-op’d (
vertexCount==0). The test asserts both sides of the contract (presence inRB_EndSurface, absence invk_begin_frame) so future refactors cannot accidentally reintroduce frame-ordering regressions without failing CI.Validation
tests/scripts/test_vk_vegetation_dispatch_order.shctest -R test_vk_vegetation_dispatch_order --output-on-failure(after reconfigure)