feat(skills): pinpoint-superpowers-bridge — map lifecycle onto beads (PP-140e.7)#1609
Open
timothyfroehlich wants to merge 2 commits into
Open
feat(skills): pinpoint-superpowers-bridge — map lifecycle onto beads (PP-140e.7)#1609timothyfroehlich wants to merge 2 commits into
timothyfroehlich wants to merge 2 commits into
Conversation
…(PP-140e.7) Project-side shim for running the superpowers plugin lifecycle in PinPoint. Codifies the field conventions (specs/plans stay as files in git; beads carry pointers via --spec-id/--design/--acceptance/--notes) and overrides the superpowers steps that conflict with PinPoint rules: - finishing-a-development-branch: no local merge → PR + merge-pr.sh + landing the plane; tiered pnpm tests not npm/pytest; worktree cleanup via the WorktreeRemove hook on confirmation; close bead only after merge - subagent-driven-development: clear the multi-agent scale gate first - requesting/receiving-code-review: CI Gate + /code-review; replies via MCP, —Claude - brainstorm→bead "step 6.5" wiring; all lifecycle writes happen in a worktree Adds AGENTS.md §3 index row + a "Superpowers lifecycle → beads" pointer. R21–R23 of the 2026-07 devx review. R24 (merge-to-main backstop) routed to PP-140e.2; end-to-end trial split to PP-140e.11. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new project skill to bridge the “superpowers” plugin lifecycle into PinPoint’s bead/worktree/PR workflows, and documents when/how to use it in AGENTS.md.
Changes:
- Add
.agents/skills/pinpoint-superpowers-bridge/SKILL.mddefining bead field conventions (spec/plan pointers) and PinPoint-specific overrides for conflicting superpowers steps. - Update
AGENTS.mdto list the new skill and document the “superpowers lifecycle → beads” mapping and field usage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| AGENTS.md | Adds the new skill to the skills table and documents when to load it + bead field mapping for superpowers lifecycle. |
| .agents/skills/pinpoint-superpowers-bridge/SKILL.md | Introduces the bridge skill content: bead field conventions + lifecycle overrides (worktrees, subagents, review, finishing). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+59
to
+60
| - Superpowers says "never pause between tasks, dispatch a fresh subagent per task." PinPoint gates multi-agent orchestration: **before launching, state the subagent count + rough cost and get Tim's explicit yes** (CLAUDE.md "Multi-Agent Workflows scale gate"). The built-in `/code-review` workflow is the only exemption. | ||
| - Caps: ~2–4 subagents per task; **simple PRs (<5 files) ≤ 2 subagents** (CLAUDE.md). Don't fan out on straightforward work. |
| ### `requesting-code-review` / `receiving-code-review` | ||
|
|
||
| - Superpowers' reviewer-subagent is fine as an **optional local self-check**. The **authoritative** review gate is **CI Gate + `/code-review`** (see `pinpoint-pr-workflow`), not a plugin subagent. | ||
| - **Reply to review comments via MCP** (`add_reply_to_pull_request_comment` + resolve the thread with `pull_request_review_write method:"resolve_thread"`), **signed `—Claude`** (AGENTS.md §5 "Review comments"). Declined comments still get a one-sentence reply — no silent ignores. Do not use the plugin's own reply flow. |
| | Plan written | record path + branch in `--design` (§1) | | ||
| | Worktree create | `EnterWorktree` / `Agent(isolation:"worktree")`, from main worktree | | ||
| | SDD dispatch | clear the scale gate (count + cost, Tim's yes) first | | ||
| | Code review | CI Gate + `/code-review`; replies via MCP, signed `—Claude` | |
|
|
||
| - **Never merge locally, never push/merge to `main`.** Ship through a PR: push the branch, open it **ready-for-review**, let **CI** run the full suite, then merge **only** via `scripts/workflow/merge-pr.sh <PR>` (never `gh pr merge` / MCP merge). Full pipeline: `pinpoint-pr-workflow` + landing-the-plane (AGENTS.md §9). | ||
| - **Tests:** use PinPoint's tiered commands (`pnpm run check` floor; `pnpm run preflight` for migrations/auth/server-actions/middleware/schema; `pnpm run smoke` for UI) — **not** `npm test` / `pytest`. Don't run the full E2E suite locally; CI owns it. | ||
| - **Worktree cleanup is destructive → wait for explicit confirmation** (AGENTS.md §9.6). When confirmed, cleanup goes through the `WorktreeRemove` hook / `scripts/worktree_cleanup.py` (dealloc slot + Docker volumes) — **never raw `git worktree remove`/`rm -rf`**, which leaks the slot manifest and volumes. |
|
|
||
| ### `using-git-worktrees` | ||
|
|
||
| - PinPoint has native worktree tooling — **use `EnterWorktree`** (or `Agent(isolation:"worktree")`), never raw `git worktree add`. The `post-checkout` hook wires ports/env/config. 6.1.x already prefers native tools; this just names ours. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
.agents/skills/pinpoint-superpowers-bridge/SKILL.md— the project-side shim for running the superpowers plugin lifecycle (brainstorming → writing-plans → subagent-driven-development → finishing-a-development-branch) inside PinPoint, plus the AGENTS.md wiring. Implements R21–R23 of the 2026-07 devx review (Tier 5).The plugin's skills live in an unwritable cache, so PinPoint can't edit them; this skill declares which steps to follow verbatim and which to override.
Field conventions (R21)
Specs/plans stay as files in git (their superpowers default locations, kept as records — AGENTS.md §8). Beads carry pointers, not copies:
--spec-id= spec path--design= plan path(s) + branch name while unmerged (recover viagit show origin/<branch>:<path>)--acceptance= distilled criteria--notes= landing breadcrumbsPlan-file checkboxes are within-PR execution state, not durable task tracking — the bead is the cross-session source of truth.
Overrides (verified against superpowers 6.1.1)
scripts/workflow/merge-pr.sh→ landing-the-plane. Tieredpnpmtests, notnpm test/pytest. Worktree cleanup via theWorktreeRemovehook on confirmation, never rawgit worktree remove. Close the bead only after merge./code-review; replies via MCP, signed—Claude.Scope
writing-skillsdiscipline the RED state is self-evident from the plugin text; PP-140e.11 is the real GREEN test, so no synthetic subagent scenarios (agreed with Tim).Note
pnpm run checkis red locally ontypecheck:tests(~20 test-type errors) — inherited frommain(PR #1388's Machine Settings tests not captured by PR #1584's baseline, a merge-ordering gap; CI doesn't run that gate). This PR changes only two.mdfiles (git diff origin/mainexcluding*.mdis empty). Tracked separately.🤖 Generated with Claude Code