fix(worktree): make checkout timeout configurable - #192
Open
bold84 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
worktreeTimeoutSecondsin global/projectsubagents.json.autostrategy that scales from tracked file count (60-second floor, 5 ms per tracked file, 30-minute cap) plus bounded fixed values from 30 to 3600 seconds./agents -> Settings -> Worktree timeout.git rev-parse --show-prefixfor subdirectory mapping so Windows 8.3 and long path forms do not produce an incorrectworkPath.Motivation
The previous implementation used a hardcoded 30-second
execFileSynctimeout. On a Windows repository with approximately 85,550 tracked files, checkout exceeded that limit and surfaced the generic “not a git repo / no commits / git worktree add failed” error. The timed-out checkout could also leave a locked partial worktree behind.Validation
npm run typechecknpm run lintnpm run buildnpm test -- test/settings.test.ts test/worktree.test.ts— 79 tests passedThe complete suite was also run on Windows. 42 files passed; the remaining failures are existing environment-sensitive tests that assume POSIX path formatting or an empty global custom-agent directory.