Skip to content

Improve theme toggle #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tklepzig merged 1 commit into from
Aug 6, 2026
Merged

Improve theme toggle #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
108 changes: 70 additions & 38 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,41 +81,53 @@
<div class="panel">
<header>
<h1>Ada UI</h1>
<div class="panel-dock">
<div class="panel-dock" id="theme-dock-narrow">
<button
id="theme-cycle"
class="command thin"
onclick="cycleTheme()"
></button>
<button
class="command thin tone-3 mode-toggle"
onclick="toggleMode()"
></button>
</div>
<div class="panel-dock" id="theme-dock-wide">
<button
class="command thin tone-4"
data-theme="teal"
data-label="Teal"
data-abbr="T"
data-short="Te"
onclick="selectTheme(this)"
></button>
>
Teal
</button>
<button
class="command thin"
data-theme="blue"
data-label="Blue"
data-abbr="B"
data-short="Bl"
onclick="selectTheme(this)"
></button>
>
Blue
</button>
<button
class="command thin"
data-theme="green"
data-label="Green"
data-abbr="G"
data-short="Gr"
onclick="selectTheme(this)"
></button>
>
Green
</button>
<button
class="command thin"
data-theme="jupiter-2"
data-label="Jupiter 2"
data-abbr="J2"
data-short="J2"
onclick="selectTheme(this)"
></button>
>
Jupiter 2
</button>
<button
id="mode-toggle"
class="command thin tone-3"
data-label="Light"
data-abbr="L"
onclick="toggleMode(this)"
class="command thin tone-3 mode-toggle"
onclick="toggleMode()"
></button>
</div>
</header>
Expand Down Expand Up @@ -607,39 +619,59 @@ <h3>16px</h3>
<footer></footer>
</div>
<script>
let currentTheme = storedTheme ?? "teal";

const themeButtons = () =>
document.querySelectorAll("#theme-dock-wide [data-theme]");

function selectTheme(selected) {
document.getElementById(
"theme-override",
).href = `css/ada.${selected.dataset.theme}.css`;
markActiveTheme(selected.dataset.theme);
store(THEME_KEY, selected.dataset.theme);
applyTheme(selected.dataset.theme);
}

function nextThemeButton() {
const buttons = [...themeButtons()];
const current = buttons.findIndex(
(button) => button.dataset.theme === currentTheme,
);
return buttons[(current + 1) % buttons.length];
}

function cycleTheme() {
applyTheme(nextThemeButton().dataset.theme);
}

function applyTheme(theme) {
currentTheme = theme;
document.getElementById("theme-override").href = `css/ada.${theme}.css`;
markActiveTheme(theme);
store(THEME_KEY, theme);
}

function toggleMode(toggle) {
function toggleMode() {
const isLight =
document.documentElement.classList.toggle("light-theme");
setModeLabel(toggle, isLight);
setModeLabel(isLight);
store(LIGHT_KEY, isLight);
}

function setModeLabel(toggle, isLight) {
toggle.dataset.label = isLight ? "Dark" : "Light";
toggle.dataset.abbr = isLight ? "D" : "L";
function setModeLabel(isLight) {
document
.querySelectorAll(".mode-toggle")
.forEach(
(toggle) => (toggle.textContent = isLight ? "Dark" : "Light"),
);
}

function markActiveTheme(theme) {
document
.querySelectorAll("[data-theme]")
.forEach((button) =>
button.classList.toggle("tone-4", button.dataset.theme === theme),
);
themeButtons().forEach((button) =>
button.classList.toggle("tone-4", button.dataset.theme === theme),
);
document.getElementById("theme-cycle").textContent =
nextThemeButton().dataset.short;
}

markActiveTheme(storedTheme ?? "teal");
setModeLabel(
document.getElementById("mode-toggle"),
document.documentElement.classList.contains("light-theme"),
);
markActiveTheme(currentTheme);
setModeLabel(document.documentElement.classList.contains("light-theme"));
</script>
</body>
</html>
12 changes: 12 additions & 0 deletions style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,3 +197,15 @@ body {
input {
max-width: 20rem;
}

@media (width < 640px) {
#theme-dock-wide {
display: none;
}
}

@media (width >= 640px) {
#theme-dock-narrow {
display: none;
}
}