Draft
Conversation
Copilot created this pull request from a session on behalf of
tkreuzer
August 3, 2026 13:45
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four independent bugs in the new AHCI pciidex driver, one commit each.
Duplicate macro (
ahci.h)AHCI_PXCMD_ICC_DEVSLEEPwas defined twice on consecutive lines. Removed the duplicate.Missing format specifier (
pdo.c)Tautological ASSERT (
ahci_generic.c)ASSERT(Controller->MaxChannels == 0)insideif (Controller->MaxChannels == 0)is always true and never fires. Replaced withASSERT(FALSE)to mark the path as unexpected.Wrong bitwise operators in
AtaAhciFbsControl(ahci_hw.c)&and^were swapped in the condition that guards the PxFBS register write:The original expression evaluated non-zero (triggering a write) in cases where FbsControl had other status bits set even when the ENABLE bit was already in the desired state.