fix: resolve sourceLayers from sourceLayersWithOverrides in rundown content status - #7
Merged
Merged
Conversation
…ontent status DBShowStyleBase stores source layers in sourceLayersWithOverrides, not sourceLayers. Apply overrides before looking up piece source layers, matching the pattern used elsewhere in pieceContentStatusUI. Co-authored-by: Jakub Doboš <kubo6472@users.noreply.github.com>
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kubo6472
marked this pull request as ready for review
July 17, 2026 09:25
Co-authored-by: Jakub Doboš <kubo6472@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a TypeScript build error in
rundownContentStatus.tswheresourceLayerswas accessed directly onDBShowStyleBase.DBShowStyleBasestores source layers insourceLayersWithOverrides, notsourceLayers. This change applies overrides before looking up piece source layers, matching the pattern used elsewhere inpieceContentStatusUI.Also fixes a Prettier formatting error in
peripheralDevice.tsfor thegetContentStatusForRundownmethod signature.Changes
applyAndValidateOverridesfrom corelibgetContentStatusForRundownparameters to a single line per PrettierTest plan
tsc --build tsconfig.build.jsonpasses without TS2339 onrundownContentStatus.ts