Skip to content

fix: resolve sourceLayers from sourceLayersWithOverrides in rundown content status - #7

Merged
kubo6472 merged 2 commits into
mainfrom
cursor/fix-source-layers-type-error-5a9f
Jul 17, 2026
Merged

fix: resolve sourceLayers from sourceLayersWithOverrides in rundown content status#7
kubo6472 merged 2 commits into
mainfrom
cursor/fix-source-layers-type-error-5a9f

Conversation

@kubo6472

@kubo6472 kubo6472 commented Jul 17, 2026

Copy link
Copy Markdown
Member

Summary

Fixes a TypeScript build error in rundownContentStatus.ts where sourceLayers was accessed directly on DBShowStyleBase.

DBShowStyleBase stores source layers in sourceLayersWithOverrides, not sourceLayers. This change applies overrides before looking up piece source layers, matching the pattern used elsewhere in pieceContentStatusUI.

Also fixes a Prettier formatting error in peripheralDevice.ts for the getContentStatusForRundown method signature.

Changes

  • Import applyAndValidateOverrides from corelib
  • Resolve source layers once before iterating pieces
  • Look up each piece's source layer from the resolved map
  • Collapse getContentStatusForRundown parameters to a single line per Prettier

Test plan

  • tsc --build tsconfig.build.json passes without TS2339 on rundownContentStatus.ts
Open in Web Open in Cursor 

…ontent status

DBShowStyleBase stores source layers in sourceLayersWithOverrides, not
sourceLayers. Apply overrides before looking up piece source layers,
matching the pattern used elsewhere in pieceContentStatusUI.

Co-authored-by: Jakub Doboš <kubo6472@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Caution

Review failed

An error occurred during the review process. Please try again later.

✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch cursor/fix-source-layers-type-error-5a9f

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kubo6472
kubo6472 marked this pull request as ready for review July 17, 2026 09:25
Co-authored-by: Jakub Doboš <kubo6472@users.noreply.github.com>
@kubo6472
kubo6472 merged commit 581076c into main Jul 17, 2026
43 checks passed
@kubo6472
kubo6472 deleted the cursor/fix-source-layers-type-error-5a9f branch July 17, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants