fix(common-utils): escape single quotes in zz_args eval output - #87
Open
tomgrv wants to merge 2 commits into
Open
fix(common-utils): escape single quotes in zz_args eval output#87tomgrv wants to merge 2 commits into
tomgrv wants to merge 2 commits into
Conversation
zz_args emits var='<value>' lines that callers pass to eval. A value containing a single quote broke out of the quoting, letting arbitrary shell commands run. Added zz_esc() to escape embedded quotes before they're wrapped in single quotes, applied across all capture modes (flag values, positional, +, &, #).
tomgrv
marked this pull request as ready for review
July 18, 2026 20:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zz_argsemitsvar='<value>'assignments that callers wrap ineval $(zz_args ...). Any argument value containing a single quote broke out of the quoting, letting arbitrary shell commands run in the caller's context.zz_esc()helper (escapes'as'\'') and applied it to every value-emitting code path: flag values (OPTARG), positional-args, and the&,#,+remaining-argument capture modes.Test plan
_zz_args.shaszz_argsonPATHalongside a minimal caller script usingeval $(zz_args ... <<-help ... help), matching real usage insrc/gitutils/_git-fix-base.shand similar scripts.main'; touch /tmp/pwned; echo ') execute the injectedtouchcommand.-),&,#, and+capture modes, while normal values (including embedded spaces) still parse correctly.Generated by Claude Code