Make all traps attackable and give them configurable HP

[Upabjojr]

Proposal 1 of a set of PRs following the mechanics discussion in #23 (#23 (comment)) — this one covers the part Tom was certain about: "anyway Traps should be destructible".

It turns out the attack machinery for traps already exists end to end (per-tile HP, Building::takeDamage, target discovery in GameMap::getVisibleForce, fight actions) — but TrapSpike and TrapBoulder override isAttackable() to false, so only cannons and wooden doors could actually be fought. This PR:

• Removes those two overrides, so spike and boulder traps can be attacked and destroyed like cannons already could. The vision gate in Trap::isAttackable is deliberately kept: a trap that a player has never seen trigger stays invisible and unattackable for them, so hidden traps remain a real threat.
• Makes trap HP configurable per trap type. Tile HP was a flat Building::DEFAULT_TILE_HP = 10.0 for every building in the game. Traps now read BoulderHP, CannonHP, SpikeHP, WoodenDoorHP from traps.cfg via a new getTrapConfigDoubleOrDefault(), which falls back to the old value of 10 when the entry is missing — older/custom config files keep working unchanged.

The shipped values (Spike 10, Boulder 15, Cannon 20, WoodenDoor 25) are conservative first guesses to make sturdiness roughly track cost — obviously up for balance discussion, that's why they're config entries.

Not touched here: traps were already claimable tile-by-tile by enemy workers (Trap::claimForSeat destroys the danced tile), and that stays as it is.

Validated: builds and the full test suite passes (including ab-TestTraps) via ctest.

🤖 Generated with Claude Code

[tomluchowski]

For destructible traps I am by whole heart .... For the destructible rooms I feel the opposite: they should only be reclaimable between players. That needs to be discussed, but no one says anything at our discord channel.

[Upabjojr]

Glad the traps part has your whole heart — that part is this PR, and it changes nothing about rooms.

On the rooms side, one correction to the premise, because it matters for the discussion: "rooms only reclaimable" is not the current behaviour you'd be preserving — rooms are already destructible in the game today. Enemy fighters target visible enemy rooms and knock tiles out at a flat 10 HP each (Building::DEFAULT_TILE_HP) — a mid-level creature removes a tile in a couple of swings. That is mainline behaviour, before any of these PRs; #33 doesn't introduce room destruction, it introduces the knob that until now didn't exist.

And the knob now covers your preference directly: I've just pushed a commit to #33 (19ae3288) making <RoomName>HP = 0 in rooms.cfg mean indestructible — the room cannot be attacked at all and can only change hands through claiming. So "rooms are reclaim-only" stops being a code fork and becomes one config line per room type; if that's where the Discord consensus lands, we just ship that as the default config. Meanwhile whoever wants DK-style siege damage sets a finite HP.

🤖 Generated with Claude Code