Stop tile recolouring from stacking material clones until tiles vanish

[Upabjojr]

This is the actual cause of the disappearing bridge meshes on the ForgottenTreasures2 level from #34.

colourizeMaterial() names its colourized copy by appending the colour suffix to the material it was given, and colourizeEntity() recovers the original material by cutting the name at a ## separator. The separator was commented out of the append in the Z pre-pass work (understandably — the outliner/brighter suffixes use ## too, and a generic find("##") strip would eat theirs), so every recolour since then has been cloning the already colourized material and growing the name by one more suffix: WoodBridge → WoodBridgeColor_1_ → WoodBridgeColor_1_Color_2_ → … one fresh Ogre material per refresh.

Tiles that rarely change colour hide this well. Bridge claiming walks right into it: every handover refreshes the square and its neighbours, the clone chain grows by a link each time, and a few claims in, the cloned material stops rendering — the planks vanish from the map while the server keeps correctly reporting the bridge (I verified the packets: hasBridge=1, WoodBridge.mesh, waterGround all the way through). That's why #34 makes it visible: square-by-square claiming multiplies the recolour events. The bug itself is independent of #34 and was quietly leaking a material clone on every tile recolour.

The fix brings the separator back as @@, which nothing else uses: recolouring now replaces the suffix instead of stacking it, the find("##_Outliner")/find("##_Brighter") checks can never match a colourized name, and the set of materials stays bounded at one per (material, seat colour, dig mark, vision) combination. colourizeEntity() is only ever called for tile meshes and bridge meshes, so nothing else changes behaviour.

Verified on your level with seat 2's workers claiming WoodenBridge_9 in skirmish:

• unfixed: five claimed squares lost their planks within a minute, exactly as you reported;
• fixed: all 27 squares stay drawn through 14 handovers, recoloured to the claimer's colour square by square, and the material name stays WoodBridge@@Color_2_ instead of growing without bound.

Loading the level in the editor and in skirmish before any claims looks identical before/after.

🤖 Generated with Claude Code

https://claude.ai/code/session_014hrk8PiEUMgjYJnTxLF2PU