Add PINI=YES to the records named in the settings request files - #186
Open
xmap wants to merge 1 commit into
Open
Add PINI=YES to the records named in the settings request files#186xmap wants to merge 1 commit into
xmap wants to merge 1 commit into
Conversation
Autosave restores these at boot without processing them, so they come back carrying the right value but with no EPICS timestamp, and STAT still at UDF. Channel Access clients recording scan provenance cannot date the setting, and array-backed records additionally come back INVALID. PINI=YES makes each record process once at iocInit, after both restore passes, so the restored value is the one that gets stamped. Scope is exactly the records listed in tomoScan_settings.req and tomoScan_2BM_settings.req. None of them has an OUT, INP, DOL, FLNK or SDIS field, so processing writes nothing out, reads nothing in and triggers nothing. The busy command records (StartScan, AbortScan, MoveSampleIn, MoveSampleOut) are commented out of the request file and so are not in scope. Verified on a scratch IOC (base 7.0.8, autosave R5-11) across a restart. Refs tomography#182
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #182. Autosave restores these records at boot without processing them, so they come back with the right value but no EPICS timestamp and
STATstill atUDF. A client recording scan provenance cannot date the setting.PINI=YESmakes each record process once atiocInit, which runs after both autosave restore passes (initHookAfterInitDevSupandinitHookAfterInitDatabase), so it is the restored value that gets stamped, not the default.Scope. Exactly the records listed in
tomoScan_settings.reqandtomoScan_2BM_settings.req, 67 records across the two templates. None has anOUT,INP,DOL,FLNKorSDISfield, so processing writes nothing out, reads nothing in, and triggers nothing downstream. Thebusycommand records @MarkRivers flagged (StartScan,AbortScan,MoveSampleIn,MoveSampleOut) are commented out of the request file and are not in scope.Verified on a scratch IOC, base 7.0.8 with autosave R5-11, across a real restart:
The waveform case was the one I most wanted to check, since PINI makes a
waveformprocess and its device support readINP. With Soft Channel and an emptyINP,read_wf()returns immediately without touchingbptrornord, so the restored buffer survives, as the table shows.Happy to extend to the other beamline templates once this shape is agreed. Worth applying after #185, which fixes the request files that silently drop their last PV.