Add back themeConfigMap to UI v2 load options; deprecate CSS related theme props#203
Open
linh-transcend wants to merge 3 commits into
Open
Add back themeConfigMap to UI v2 load options; deprecate CSS related theme props#203linh-transcend wants to merge 3 commits into
themeConfigMap to UI v2 load options; deprecate CSS related theme props#203linh-transcend wants to merge 3 commits into
Conversation
@transcend-io/airgap.js-types
@transcend-io/cli
@transcend-io/internationalization
@transcend-io/privacy-types
@transcend-io/sdk
@transcend-io/type-utils
@transcend-io/utils
@transcend-io/mcp
@transcend-io/mcp-server-admin
@transcend-io/mcp-server-assessment
@transcend-io/mcp-server-base
@transcend-io/mcp-server-consent
@transcend-io/mcp-server-discovery
@transcend-io/mcp-server-dsr
@transcend-io/mcp-server-inventory
@transcend-io/mcp-server-preferences
@transcend-io/mcp-server-workflows
commit: |
linh-transcend
commented
Jun 12, 2026
| export const HeaderTheme = t.intersection([ | ||
| /** @deprecated - Removed in favor of CSS styling */ | ||
| t.partial(Text.props), | ||
| t.type({ logoPosition: valuesOf(LogoPosition), logoImageUrl: AbsoluteUrlString }), |
Member
Author
There was a problem hiding this comment.
logoImageUrl was accidentally left out here but was assumed to be here in the UI and monorepo.
linh-transcend
commented
Jun 12, 2026
| CommonLayerTheme, | ||
| t.type({ | ||
| contentFlow: valuesOf(ContentFlows), | ||
| contentLayout: ContentLayout, |
Member
Author
There was a problem hiding this comment.
This was left out too but present in the monorepo and ui repo
csmccarthy
reviewed
Jun 12, 2026
| }), | ||
| t.partial({ | ||
| header: HeaderTheme, | ||
| /** @deprecated - Removed in favor of CSS styling */ |
Member
There was a problem hiding this comment.
why mark deprecated rather than just remove these?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
themeConfigMapsince we still want to use some non-CSS related props in the UI.