Skip to content

Implement SignSubtree in witness client - #591

Merged
roger2hk merged 2 commits into
transparency-dev:mainfrom
roger2hk:client-subtree
Aug 14, 2026
Merged

Implement SignSubtree in witness client#591
roger2hk merged 2 commits into
transparency-dev:mainfrom
roger2hk:client-subtree

Conversation

@roger2hk

Copy link
Copy Markdown
Contributor

This pull request implements the /sign-subtree endpoint in witness client according to the tlog-witness specification.

@roger2hk
roger2hk requested review from AlCutter and phbnf August 14, 2026 11:56
@roger2hk roger2hk added the enhancement New feature or request label Aug 14, 2026
@codecov-commenter

codecov-commenter commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.45455% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.92%. Comparing base (61e4168) to head (e233842).

Files with missing lines Patch % Lines
client/http/witness_client.go 70.45% 8 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #591      +/-   ##
==========================================
+ Coverage   24.91%   25.92%   +1.01%     
==========================================
  Files          29       29              
  Lines        2408     2449      +41     
==========================================
+ Hits          600      635      +35     
- Misses       1680     1681       +1     
- Partials      128      133       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread client/http/witness_client.go Outdated
Comment thread client/http/witness_client.go Outdated
@roger2hk
roger2hk merged commit 2fe0c05 into transparency-dev:main Aug 14, 2026
14 checks passed
@roger2hk
roger2hk deleted the client-subtree branch August 14, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants