Signed angle 2D#76
Closed
xix-xeaon wants to merge 2 commits intotreeform:masterfrom
Closed
Conversation
Owner
|
Thank you for this PR. I also realized that angle function was a problem. I think this PR fixes it in a much broader way with quaternions and comparisons to other vector libraries. 7bd9f6e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spent a lot of time trying to figure out why my code wasn't working, before finally identifying the angle function as the cause of the error. I thought I had the latest version but I didn't so I missed the fix in #74 and eventually solved it myself.
Sometime later I thought I should contribute my fix, only this time I discovered that the problem had already been solved. However, upon updating I realized that the function in #74 discards the sign of the angle, which is unfortunate because that information is extremely useful for a lot of things.
This version keeps the sign information (+PI to -PI), with positive values in the CCW direction as is traditional.