Move CatHub configuration ownership out of QsoRipper#554
Draft
rtreit wants to merge 1 commit into
Draft
Conversation
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes CatHub the only owner of CatHub configuration, defaults, migration, and semantic validation.
QsoRipper now preserves
[cat_hub]as opaque data. Both engines keep only rigctld and CW client settings. The setup protocol reserves the removed CatHub fields and wizard value. The CLI and GUI direct operators to the standalone CatHub configuration command.The change removes the duplicate CatHub schema, engine parser, engine writer, setup wizard step, and GUI editor. It also updates the engine specification and CatHub integration guide.
Validation completed with
.\build.ps1 check-rustand.\build.ps1 check-dotnet. Rust line coverage is 80.16 percent. .NET line coverage is 52.5 percent.Closes #477
Part of #540.