build: bump fastapi and starlette pins in openai frontend - #8941
Merged
Conversation
mc-nv
marked this pull request as ready for review
August 26, 2026 16:51
whoisj
approved these changes
Aug 26, 2026
Greptile SummaryUpdates the OpenAI frontend’s coupled FastAPI and Starlette dependency pins to include the Starlette security fix while remaining within vLLM’s FastAPI compatibility range.
Confidence Score: 5/5The PR appears safe to merge, with no actionable defects identified in the coordinated dependency update. The changed pins preserve the documented vLLM FastAPI range while raising Starlette to the security-fixed release, and the investigated advisory leads were neither introduced nor made reachable by this change. Important Files Changed
Reviews (1): Last reviewed commit: "build: bump fastapi and starlette pins i..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Backports the fastapi and starlette pin bump to
r26.08, so the release branchpicks up the starlette CVE fix.
starlettemoves to>=1.3.1,<2. That floor cannot be met by the pinnedfastapi, because releases before 0.133.0 cap starlette below 1.0, so
fastapimoves to
0.136.3. The upper bound stays below 0.137.0 because vllm requiresfastapi[standard]<0.137.0,>=0.133.0. The two pins are coupled, which is whythey move together.
Cherry-picked from the change already merged to
main.Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
Where should the reviewer start?
python/openai/requirements.txt— confirm the backported pins match what landedon
mainand that the vllm constraint still holds for the 26.08 train.Test plan:
Diff against
r26.08is a single file,+5/-5, identical to the change mergedto
main.Caveats:
The fastapi bound is dictated by vllm's own requirement range, so a future vllm
bump on this branch may need this revisited.
Background
Part of the post-code-freeze security scan pass for 26.08. The CVE fix landed on
mainfirst and is backported here so the release branch is not left on thevulnerable starlette range.
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)