Skip to content

ci: replace SPDX header with LICENSE header on L0_torch_aoti_hstu (TRI-1654) - #8942

Merged
pskiran1 merged 1 commit into
mainfrom
asaraswathi/tri-1654-fix-torch-aoti-copyright
Aug 27, 2026
Merged

ci: replace SPDX header with LICENSE header on L0_torch_aoti_hstu (TRI-1654)#8942
pskiran1 merged 1 commit into
mainfrom
asaraswathi/tri-1654-fix-torch-aoti-copyright

Conversation

@akhilraj9

@akhilraj9 akhilraj9 commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

What does the PR do?

Converts the two-line SPDX header on qa/L0_torch_aoti_hstu/test.sh to the long-form BSD LICENSE header that qa/common/check_copyright.py requires. This was the last remaining copyright violation failing the nightly L0_copyrights job.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

  • ci

Related PRs:

Part of TRI-1654. Companion changes already merged:

  • server #8928 — copyright header on qa/L2_build_presets/requirements.txt
  • server_ci (internal) !1855 — copyright headers on the RHEL tutorial tests

Where should the reviewer start?

qa/L0_torch_aoti_hstu/test.sh — the header swap is the entire diff (+25/-2).

Test plan:

  • python3 qa/common/check_copyright.py --year=2026 * → exit 0 (was exit 1 on this file). Last remaining violation, so the nightly L0_copyrights goes green.
  • CI Pipeline ID: 64723722

Caveats:

None — header-only change, no functional or behavioral impact.

Background

The file was added (#8907) with a two-line SPDX header. check_copyright.py only accepts the long-form BSD header, and the add-license pre-commit hook doesn't convert SPDX (it sees the SPDX copyright line as already present), so it slipped through and broke the nightly. Same class of fix as 82cf9596.

Related Issues:

  • Relates to TRI-1654 (internal Linear). No GitHub issue.

…TRI-1654)

check_copyright.py rejects the two-line SPDX header on
qa/L0_torch_aoti_hstu/test.sh, failing the nightly L0_copyrights job.
Convert to the long-form BSD LICENSE header, matching 82cf959.

Signed-off-by: Akhil <asaraswathi@nvidia.com>
@akhilraj9 akhilraj9 self-assigned this Aug 26, 2026
@akhilraj9
akhilraj9 requested review from pskiran1 and yinggeh August 26, 2026 18:44
@greptile-apps

greptile-apps Bot commented Aug 26, 2026

Copy link
Copy Markdown

Greptile Summary

This PR replaces the SPDX metadata in qa/L0_torch_aoti_hstu/test.sh with the repository-required long-form BSD license header, allowing the copyright check to accept the file.

  • Preserves the shebang and all executable test behavior.
  • Changes comments only; no runtime logic or security boundaries are affected.

Confidence Score: 5/5

The PR appears safe to merge because it changes only comment-form licensing text and preserves the script’s behavior.

The shebang remains first, and every changed line is a shell comment containing the replacement license header; no functional failure remains.

Important Files Changed

Filename Overview
qa/L0_torch_aoti_hstu/test.sh Replaces the two-line SPDX header with the long-form BSD license text without altering executable shell code.

Reviews (1): Last reviewed commit: "ci: replace SPDX header with LICENSE hea..." | Re-trigger Greptile

@pskiran1
pskiran1 merged commit e8284d8 into main Aug 27, 2026
4 checks passed
@pskiran1
pskiran1 deleted the asaraswathi/tri-1654-fix-torch-aoti-copyright branch August 27, 2026 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants