Nix flake - #123
Open
kratochvil-jan wants to merge 4 commits into
Open
Conversation
trnila
reviewed
May 24, 2026
| }; | ||
|
|
||
| config = lib.mkIf cfg.enable { | ||
| users.users.lunch-assistant = { |
Owner
There was a problem hiding this comment.
i would use Systemd dynamic user, or nobody
| RestartSec = 5; | ||
|
|
||
| StateDirectory = "assistant"; | ||
| RuntimeDirectory = "assistant"; |
Owner
There was a problem hiding this comment.
I would omit these dirs - theres no state in the service itself, but in redis instead
| # from flask_redis import FlaskRedis | ||
| from lunches import RestaurantMenu, gather_restaurants | ||
| from public_transport import public_transport_connections | ||
| from .lunches import RestaurantMenu, gather_restaurants |
Owner
There was a problem hiding this comment.
does it strictly require package directory? If so, i would rename it maybe to assistant or lunchmenu - but theres still transport miniapp
|
|
||
| yarnOfflineCache = pkgs.fetchYarnDeps { | ||
| yarnLock = ../frontend/yarn.lock; | ||
| hash = "sha256-6xzFsvoGzzhizfDiHuzb4A3G1M48dNziJZ8PxcgOqFU="; |
Owner
There was a problem hiding this comment.
not sure if renovatebot will catch this?
| # | ||
| openFirewall = lib.mkOption { | ||
| type = lib.types.bool; | ||
| default = true; |
Owner
There was a problem hiding this comment.
not sure about firewall here - some proxy (traefik/nginx) is needed to support more services and HTTPS termination
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
derivation configs for building:
nix build .#frontendnix build .#backendnix run .#appexperimental management of pre-commit via nix flake:
nix flake check- fails on ruff right nownix develop- running this would install the pre commit YAML filenixos module to run the lunch assistant as native service - untested