[codex] add competition setup flow before starting a game#19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch introduces a proper pre-game setup flow and standardises the domain language around
competition.What changed
Competitioncomponent and/competitionpage for creating competition details/setupbefore a user can reach/gamechampionshipterminology across code, relationships, labels, variables, and schema references withcompetitionWhy
Issue #16 required the single-game flow to include a real setup experience before a game can start. The branch also removes the mixed
championship/competitionterminology that was leaking through the codebase and UI.Impact
Users are now guided through the required setup steps before starting a game, can create and edit the competition inline during setup, and see consistent competition terminology throughout the application.
Validation
php artisan test --compact tests/Feature/CompetitionPageTest.phpphp artisan test --compact tests/Feature/MatchSetupRoutingTest.phpphp ./vendor/bin/phpstan analyse app/ database/factories/ database/seeders/ --memory-limit=2G --debugvendor/bin/pint --dirty --format agentvendor/bin/rector process --clear-cache --memory-limit=2GCloses #16