Skip to content

bump: bring latest compute-pcrs - #338

Closed
bgartzi wants to merge 1 commit into
trusted-execution-clusters:mainfrom
bgartzi:bump-compute-pcrs-lief-removal
Closed

bump: bring latest compute-pcrs#338
bgartzi wants to merge 1 commit into
trusted-execution-clusters:mainfrom
bgartzi:bump-compute-pcrs-lief-removal

Conversation

@bgartzi

@bgartzi bgartzi commented Aug 17, 2026

Copy link
Copy Markdown
Member

This removes lief as a dependency in favor of the object and authenticode crates.

Summary by Sourcery

Enhancements:

  • Refresh Cargo.lock to align with updated dependencies for compute-pcrs, replacing lief with object and authenticode.

This removes lief as a dependency in favor of the object and
authenticode crates.

Signed-off-by: Beñat Gartzia Arruabarrena <bgartzia@redhat.com>
@bgartzi

bgartzi commented Aug 17, 2026

Copy link
Copy Markdown
Member Author

We might even consider telling dependabot to unignore compute-pcrs. However, there might be some changes in the existing compute-pcrs library API in the future, which would break things and require human (mine) intervention again.

@bgartzi

bgartzi commented Aug 17, 2026

Copy link
Copy Markdown
Member Author

oops, sorry for the noise. I just saw @Jakob-Naucke told dependabot to unignore compute-pcrs. no need for this.

@bgartzi bgartzi closed this Aug 17, 2026
@sourcery-ai

sourcery-ai Bot commented Aug 17, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates dependency graph to bring in the latest compute-pcrs, replacing the native lief dependency transitively with pure-Rust object and authenticode crates via Cargo.lock changes only.

File-Level Changes

Change Details Files
Refreshes Cargo.lock to point to a newer compute-pcrs release and its updated dependency set, notably removing the native lief dependency in favor of Rust object and authenticode crates.
  • Updates the resolved version and checksum for the compute-pcrs crate and any of its direct dependencies.
  • Removes entries for the previously used lief crate and any of its transitive dependencies from the lockfile.
  • Adds or updates entries for the object and authenticode crates and any new transitive dependencies required by the new compute-pcrs version.
  • Adjusts versions of any shared dependencies impacted by the new dependency tree to maintain a consistent, solvable Cargo resolution.
Cargo.lock

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant