Lewis/lp gate - #29
Merged
Merged
Conversation
- Added `isMarketing` function to determine if the marketing feature is enabled based on the `IS_MARKETING` environment variable. - Updated the proxy logic to conditionally show the landing page based on the marketing flag. - Modified tests to validate the behavior of the landing page visibility based on the marketing flag.
…sage - Added documentation for the `IS_MARKETING` environment variable in .env.example to explain its role in controlling landing page visibility. - Updated api.md to reflect changes in landing page access based on the marketing flag, clarifying the behavior for unauthenticated users and the implications of the flag on routing.
- Added detailed documentation in environment.md explaining the functionality of the `IS_MARKETING` environment variable and its impact on landing page visibility. - Clarified the conditions under which the landing page is displayed or redirected for signed-out users, emphasizing the importance of the flag's value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Make the landing page opt-in. By default, strangers only see
/sign-in; setIS_MARKETINGto the literal"true"to serve/. The proxy reads this flag on every request, so toggling it applies immediately without a rebuild.IS_MARKETING="true"to serve/to unauthenticated users.Written for commit bde4fd5. Summary will update on new commits.