LICENSE CHANGE - #35
Conversation
|
@abhinavmp076-sys is attempting to deploy a commit to the Comp AI - PoC Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="LICENSE">
<violation number="1" location="LICENSE:22">
P2: This change appends the MIT disclaimer paragraph ~12 more times (plus a stray `\`) onto the end of the license, when the PR intent was to remove the repetition. The standard MIT license is complete after the first "SOFTWARE." line; delete all of the added lines (20-118) so the file keeps a single disclaimer block and the trailing backslash/blank lines are removed.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
| LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| SOFTWARE. | ||
| \ |
There was a problem hiding this comment.
P2: This change appends the MIT disclaimer paragraph ~12 more times (plus a stray \) onto the end of the license, when the PR intent was to remove the repetition. The standard MIT license is complete after the first "SOFTWARE." line; delete all of the added lines (20-118) so the file keeps a single disclaimer block and the trailing backslash/blank lines are removed.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At LICENSE, line 22:
<comment>This change appends the MIT disclaimer paragraph ~12 more times (plus a stray `\`) onto the end of the license, when the PR intent was to remove the repetition. The standard MIT license is complete after the first "SOFTWARE." line; delete all of the added lines (20-118) so the file keeps a single disclaimer block and the trailing backslash/blank lines are removed.</comment>
<file context>
@@ -19,3 +19,100 @@ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
+\
+
+
</file context>
rajpratham1
left a comment
There was a problem hiding this comment.
This PR should not be merged in its current state because it corrupts the LICENSE file instead of improving it.
Blocking issues
- The MIT license text is duplicated repeatedly
The standard MIT license ends after the first occurrence of:
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
This PR appends the warranty/disclaimer section roughly a dozen additional times, resulting in a non-standard license file.
- Stray character introduced
Immediately after the original license ends, the diff introduces an extra:
\
This serves no purpose and should be removed.
- The resulting license is no longer the canonical MIT license
License files should match the standard text exactly (aside from the copyright holder/year). Repeating clauses creates an unnecessarily modified legal document that may confuse users and automated license scanners.
Recommendation
Restore the LICENSE to the canonical MIT form:
Keep a single copy of the disclaimer.
Remove all duplicated disclaimer blocks.
Remove the stray backslash.
Ensure the file ends immediately after the first SOFTWARE. line (with a normal trailing newline).
some of the license praragraph is repeated
Summary by cubic
Cleaned up the LICENSE by removing repeated warranty/disclaimer paragraphs. The file now matches the standard MIT license text.
Written for commit c5fa6f1. Summary will update on new commits.