Add rspec coverage for the status-history state machine - #4
Merged
Conversation
- request spec for the admin PUT controller: all 12 api_update status transitions, invalid -> 422, no-op, pre-change assignee attribution, from_status=null (no prior status), and duration from the prior change - integration spec for the post_created/topic_created handlers: customer and whisper reopens (snoozed/closed, incl. the 1-month rule), waiting_* behavior, and topic_created seeding Runs in CI (backend_tests) inside the Discourse host. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
darreneid
force-pushed
the
status-history-specs
branch
from
July 28, 2026 20:50
13bcf9d to
fffbb6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exhaustive coverage of the feature as CI-gated rspec, run inside a Discourse host (
backend_tests) — no staging instance or API key needed. Complements the deployed-instance smoke suite (#2).spec/requests/.../custom_fields_controller_spec.rb— admin PUT endpointapi_updatestatus transitions → correct row (from/to,source=api_update,user_id, nullpost_id,duration >= 0).422, nothing recorded.from_status = NULLwhen the topic had no prior status.spec/integration/status_transitions_spec.rb—post_created/topic_createdtopic_createdseedsnew(no row); a non-admin author setswaiting_*.waiting_*, no row.waiting_*, no row.Testing
Ran locally via
LOAD_PLUGINS=1 bin/rspec(identical to CI): 29 examples, 0 failures.🤖 Generated with Claude Code