[chore][MCP] Configure backend MCP service ingress domain - #352
[chore][MCP] Configure backend MCP service ingress domain#352arnold-retool wants to merge 1 commit into
Conversation
|
| Filename | Overview |
|---|---|
| charts/retool/templates/_helpers.tpl | Adds retool.mcp.backendEnvVars helper that auto-injects MCP_SERVICE_INGRESS_DOMAIN for MCP-enabled installs, with correct override detection across all three env-setting mechanisms (env, environmentSecrets, environmentVariables) |
| charts/retool/templates/deployment_backend.yaml | Single-line inclusion of the new retool.mcp.backendEnvVars helper, positioned correctly in the env block alongside other service-discovery env vars |
| charts/retool/values.yaml | Documentation updated to reflect the charts new automatic MCP_SERVICE_INGRESS_DOMAIN injection, replacing the manual env block example with a description of the auto-config and override path |
| values.yaml | Mirror of charts/retool/values.yaml documentation update; kept in sync as required |
Reviews (1): Last reviewed commit: "[chore][MCP] Configure backend MCP servi..." | Re-trigger Greptile
| {{- define "retool.mcp.backendEnvVars" -}} | ||
| {{- if .Values.mcp.enabled }} | ||
| {{- $backendHasMcpServiceIngressDomain := hasKey (.Values.env | default dict) "MCP_SERVICE_INGRESS_DOMAIN" -}} | ||
| {{- range .Values.environmentSecrets }} |
There was a problem hiding this comment.
Not sure if we need to check all these different places for MCP_SERVICE_INGRESS_DOMAIN being defined. I think we can narrow these checks down to just .Values.env.
Also wondering if there's ever even a case where the MCP_SERVICE_INGRESS_DOMAIN shouldn't just be set to value: {{ printf "http://%s:%v" (include "retool.mcp.name" .) ($mcpService.externalPort | default 4010) | quote }}? Should we even allow overriding this default?
There was a problem hiding this comment.
- Just
.Values.envcould make setup less straightforward for users with.environmentSecretsand.environmentVariablesin their charts. - An override is generally useful in cases with custom networking. I can't imagine users taking advantage of this override to break things for themselves.
Thanks for the comment! Let me know if you feel strongly about either of these.
Summary
Testing