feat(build): distinguish exit codes by severity (0=ok, 1=error, 2=waring#3212
Open
LittleLemonDrop wants to merge 14 commits into
Open
feat(build): distinguish exit codes by severity (0=ok, 1=error, 2=waring#3212LittleLemonDrop wants to merge 14 commits into
LittleLemonDrop wants to merge 14 commits into
Conversation
- Re-added hasWarnings tracking in build-file.ts, register.ts, exit-build.ts - Fixed exit code logic: 0=success, 1=errors, 2=warnings-only - Reverted test changes for boards that produce no diagnostics - build-ignore-drc-categories.test.ts correctly expects exit code 1
…oduce warnings on CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously,
tsci buildalways exited with code 0, even when circuits haderrors or warnings. This made it impossible for CI/CD pipelines and automated
agents to detect build quality from the exit code alone.
Changes
This PR introduces proper exit code conventions for
tsci build:This allows CLI consumers (scripts, CI/CD, AI agents) to determine build
quality without parsing stdout, and to fail early on errors while still
flagging warnings as actionable.
Implementation
Three files modified:
cli/build/build-file.ts: AddedhasWarningsfield toBuildFileOutcomecli/build/register.ts: Track warnings, branch exit logic by severitycli/build/utils/exit-build.ts: Color-coded messages per exit codeCloses #2292