feat: implement linear layout for decoupling capacitor partitions#115
Open
Ojas2095 wants to merge 1 commit into
Open
feat: implement linear layout for decoupling capacitor partitions#115Ojas2095 wants to merge 1 commit into
Ojas2095 wants to merge 1 commit into
Conversation
|
@Ojas2095 is attempting to deploy a commit to the tscircuit Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Hi team! Just checking in to see if you've had a chance to review this PR, or if there's any feedback or further changes needed to merge this. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #12
Closes #15
Closes #11
This PR implements a custom linear layout logic for
decoupling_capspartitions inSingleInnerPartitionPackingSolver.ts.Previously,
PackSolver2was used for all partition types, resulting in haphazard layouts for decoupling capacitors which are often better arranged linearly alongside their target IC.Changes
createLinearLayout()to position components aligned linearly._step()to usecreateLinearLayout()ifpartitionType === "decoupling_caps".This directly fixes the bad layout reproduction shown in #11 by properly orienting decoupling cap partitions in a tidy stack, allowing subsequent solvers to place this tidy group flush with the IC.
/claim #15