[MRG] Reject complex input in soft-DTW barycenters - #720
Open
mameikagou wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #720 +/- ##
==========================================
- Coverage 95.26% 94.33% -0.93%
==========================================
Files 83 83
Lines 7916 7976 +60
==========================================
- Hits 7541 7524 -17
- Misses 375 452 +77 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Author
|
All 24 Azure checks pass on The coverage job log reports a UCR/UEA dataset initialization error ( No coverage thresholds or unrelated code were changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #167.
softdtw_barycentercan discard imaginary values during conversion and return a real-only result. Reject unsupported complex datasets and initial barycenters before conversion or optimization, including complex dtypes whose imaginary part is zero. Real-valued ragged inputs remain supported.Validation: 21 barycenter tests pass, including NumPy object/ragged arrays and Torch complex and real inputs. The complex object-array regression fails on the base revision.
git diff --checkpasses.