Skip to content

fix(levoit): send speed command when leaving a preset at unchanged level #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bleialf wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

fix(levoit): send speed command when leaving a preset at unchanged level #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion components/levoit/fan/levoit_fan.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,14 @@ namespace esphome
if (call.get_speed().has_value() && (this->speed_count_ > 0))
{
int new_speed = *call.get_speed();
if (new_speed != cur_speed)
// A speed call issued while a non-Manual preset is active must still
// be sent even if the level is unchanged: the operating mode changes.
// Sleep/Auto leave this->speed at its last manual value because the
// MCU reports no fan level for those modes (apply_device_status gets
// speed_level == -1), so "same level" is not "no change" here.
const bool leaving_preset =
preset == nullptr && !cur_preset.empty() && cur_preset != "Manual";
if (new_speed != cur_speed || leaving_preset)
{
this->speed = new_speed;
speed_cmd = new_speed;
Expand Down