Refactor shard_consumer and handle expired iterators#50
Open
FugiTech wants to merge 2 commits intotwitchscience:masterfrom
Open
Refactor shard_consumer and handle expired iterators#50FugiTech wants to merge 2 commits intotwitchscience:masterfrom
FugiTech wants to merge 2 commits intotwitchscience:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves fetching records into a goroutine to try and abstract the logic in preparation for enhanced fanout. It also moves the commit loop into a goroutine to try and simplify
consume()a bit. Line 248 also adds handling for expired iterators.FugiTech#1 shows the enhanced fanout changes which rely on this PR. Let me know if you'd prefer to review them together.