Short-circuit getcoordinates() in simple cases#54
Merged
Conversation
…for large usets and large number of gid.
rjyunis
changed the title
Contributor
Author
|
In my anecdotal tests with a uset in the 10^6 gid range, this change provided a 20x speedup. This change also adheres to the return logic of a 1-d array for a single grid, and a 2-d array for multiple gid. |
Owner
|
Awesome! Thanks @rjyunis! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good morning, I've added a check to
getcoordinates()to bypass the for-loop for "simple" calls. Whencsysis 0, it's significantly faster for largeusetto call.locone time and just return the values. There is probably some way to extend that logic to the rest of the routine, but for now I think this is fine.