Skip to content

Remove partner brand reference from test fixtures - #417

Merged
dgjlindsay merged 1 commit into
stagingfrom
doug/leak-cleanup-surcharge-test-fixtures
Sep 2, 2026
Merged

Remove partner brand reference from test fixtures#417
dgjlindsay merged 1 commit into
stagingfrom
doug/leak-cleanup-surcharge-test-fixtures

Conversation

@dgjlindsay

Copy link
Copy Markdown
Contributor

Summary

  • Base-plugin unit tests used a specific partner overlay's product name as a payment-title fixture; replaced with a generic placeholder in 5 test files.
  • Tests only verify title-rendering logic, not any real brand string, so behavior is unaffected.

Test plan

  • Ran the 5 affected PHPUnit files locally (18 tests, all pass)

Base-plugin unit tests used a specific partner overlay's product name
as a payment-title fixture. Replaced with a generic placeholder — the
tests only verify title rendering, not any real brand string.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward test-fixture cleanup — string-only changes to 5 unit test files, no application code or assertion logic touched, no critical issues found.

Ready for human approval ✅

@dgjlindsay

Copy link
Copy Markdown
Contributor Author

Self-review: diff is a 1:1 fixture-string swap across 5 files — every input (setData) paired with its matching assertion (assertSame) updated consistently, no test logic changed. Ran the 5 affected PHPUnit files locally: 18 tests / 31 assertions, all pass. CI green (one DI compile (PHP 8.5, Magento 2.4.9) run hit an unrelated OOM/infra failure — exit code 137 on setup:di:compile — confirmed flaky by rerun, which passed clean).

by Claude

@dgjlindsay
dgjlindsay merged commit a4f4ab3 into staging Sep 2, 2026
55 of 56 checks passed
@dgjlindsay
dgjlindsay deleted the doug/leak-cleanup-surcharge-test-fixtures branch September 2, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant