Generalise data loading#50
Open
lang-m wants to merge 26 commits into
Open
Conversation
lang-m
commented
Jul 13, 2023
lang-m
commented
Member
- reorganise parts of the code
- handle drives with duplicated data from restarting OOMMF
This was referenced Nov 29, 2023
This functionality is calculator-specific and is moved to the individual adapter packages
samjrholt
reviewed
Jun 10, 2026
| >>> table1 = ut.Table.fromfile(odtfile1, x='t') | ||
| >>> table2 = ut.Table.fromfile(odtfile2, x='t') | ||
| >>> table1 = ut.sample_data() | ||
| >>> table2 = ut.sample_data() |
Member
There was a problem hiding this comment.
Is it worth having two different sets of data for this?
Member
Author
There was a problem hiding this comment.
I think the simplicity of just one sample dataset in the package outweighs the benefits of having two different tables to concatenate.
| table = table_llg_factory(table_kwargs={"x": "t"}) | ||
| fft_table = table.rfft() | ||
| ifft_table = fft_table.irfft() | ||
| ifft_table.x = None # TODO ASK SAM WHY THIS IS SET TO NONE |
Member
There was a problem hiding this comment.
Not sure! I think it was a work around because we could not have any arbitrary column as x?
| 2 3.000000e-09 0 0 1 | ||
| """ | ||
| data = pd.DataFrame( | ||
| { |
Member
There was a problem hiding this comment.
I like how simple the data is
Co-authored-by: Sam Holt <48217392+samjrholt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.