Skip to content

Remove arcwrapper and associated logic. - #359

Merged
jonasbardino merged 2 commits into
nextfrom
refactor/remove-arcwrapper
Nov 12, 2025
Merged

Remove arcwrapper and associated logic.#359
jonasbardino merged 2 commits into
nextfrom
refactor/remove-arcwrapper

Conversation

@ghost

@ghost ghost commented Oct 10, 2025

Copy link
Copy Markdown

Based on a response to a small cleanup attempt in acwrapper (#350 (comment)) it seems it is better to remove this code and its callsites. Do so here.

@ghost

ghost commented Oct 10, 2025

Copy link
Copy Markdown
Author

@jonasbardino I've attempted to carefully perform the removal here, incluing any blocks that conditionally ventured into ARC related things.

The only area I'm not clear on how to handle is mig/shared/mrsltoxsl.py where there are lots of references to arclib that I'm pretty sure would no longer be relevan, but I'm not completel certain what's safe to cut.

@jonasbardino

Copy link
Copy Markdown
Contributor

@jonasbardino I've attempted to carefully perform the removal here, incluing any blocks that conditionally ventured into ARC related things.

The only area I'm not clear on how to handle is mig/shared/mrsltoxsl.py where there are lots of references to arclib that I'm pretty sure would no longer be relevan, but I'm not completel certain what's safe to cut.

Thanks, the mig/shared/mrsltoxsl.py is arc-specific and should just be purged as well.

@ghost
ghost force-pushed the refactor/remove-arcwrapper branch 2 times, most recently from 1553266 to 49fee3d Compare October 11, 2025 12:45
jonasbardino added a commit that referenced this pull request Oct 13, 2025
@jonasbardino

jonasbardino commented Oct 13, 2025

Copy link
Copy Markdown
Contributor

The linting errors here are old and fixing them is covered in PR #338 and #363.

UPDATE: Rebasing after merging #363 indeed resolved those issues.

jonasbardino added a commit that referenced this pull request Oct 13, 2025
@jonasbardino
jonasbardino force-pushed the refactor/remove-arcwrapper branch from 49fee3d to 182c8ea Compare October 17, 2025 09:52
@ghost

ghost commented Nov 3, 2025

Copy link
Copy Markdown
Author

@jonasbardino have update this to the tip of next via the GitHub UI. Was there anything else that you’d wanted here? Otherwise reckon it’ll be nice to move this hunk of unused stuff out of the way.

@jonasbardino jonasbardino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. As it's only specific removals I suppose it's safe to merge.

@jonasbardino
jonasbardino merged commit 797bd6e into next Nov 12, 2025
10 checks passed
@jonasbardino
jonasbardino deleted the refactor/remove-arcwrapper branch November 12, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant