Fix issues in strip_password calls in openid service surfacing after PR592 - #641
Merged
jonasbardino merged 1 commit intoAug 18, 2026
Conversation
jonasbardino
added
bug
Contributor
Author
|
For the record one can trigger the errors in openid.log with something like on instances deployed with #592 merged. |
jonasbardino
added
the
battle-tested
…hitting openid message objects that it doesn't know what to do about. Force to string to make it succeed.
jonasbardino
force-pushed
the
fix/strip_password-use-on-grid_openid-exception-message-objects
branch
from
August 18, 2026 14:45
9f38bed to
74b3386
Compare
jonasbardino
marked this pull request as ready for review
August 18, 2026 14:47
jonasbardino
deleted the
fix/strip_password-use-on-grid_openid-exception-message-objects
branch
August 18, 2026 15:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #592 which results in
strip_passwordhelper sometimes hitting openid message objects that it doesn't know what to do about:2026-08-18 16:30:16,711 ERROR not filtering unexpected obj in strip_password: <openid.message.Message ...Force those message objects to string to make it succeed.