Fixed duplicate revenue entry for bank transfer transactions - #1
Open
sakibstime wants to merge 1 commit into
Open
Fixed duplicate revenue entry for bank transfer transactions#1sakibstime wants to merge 1 commit into
sakibstime wants to merge 1 commit into
Conversation
sakibstime
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes an issue where changing a bank transfer payment status from Pending to Approved could create a duplicate revenue entry for the same transaction.
Changes
Updated the pending payment handling by removing the duplicate transaction description assignment before calling
PaymentPending().This prevents the same bank transfer payment from being recorded twice while preserving the normal pending-to-approved payment flow.
Testing