Delete the ModelMetadata half field that only mirrored quantize - #471
Conversation
Signed-off-by: Onuralp SEZER <onuralp@ultralytics.com>
|
👋 Hello @onuralpszr, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
LGTM. The diff cleanly removes the redundant public ModelMetadata::half field, preserves legacy YAML half parsing through quantize, updates the default initializer, and adjusts the precision compatibility tests. No remaining repository references to ModelMetadata::half were found.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
🎉 PR #471 has been merged—thank you, @onuralpszr!
This change simplifies |
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Removed the redundant
ModelMetadata::halffield and its synchronization logic, keepingquantizeas the sole precision metadata representation.📊 Key Changes
half: boolfield fromModelMetadata.halfinDefaultand assignment during YAML metadata parsing.quantize.halfmetadata by mapping it toQuantization::Fp16when applicable.🎯 Purpose & Impact
ModelMetadataby eliminating a field that duplicatedquantize.quantize; consumers can no longer access the removedhalffield.