Remove dead setuptools package-data entry - #208
Conversation
|
👋 Hello @glenn-jocher, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 🤖 This is an automated message; an engineer will assist with the review. |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
Clean change. The removed setuptools package-data rule references no repository content, while the remaining configuration still uses setuptools with automatic package discovery and dynamic version loading from plugin.__version__.
|
🎉 Thank you, @glenn-jocher, for merging this PR! As Leonardo da Vinci said, “Simplicity is the ultimate sophistication.” Removing obsolete setuptools metadata keeps the project configuration cleaner, reduces maintenance overhead, and preserves the plugin’s existing behavior. We appreciate your contribution to keeping the codebase focused and reliable! |
pyproject.tomlcarriedpackage-data = { "sample" = ["*.yaml"] }from the Ultralytics Python template. There is nosamplepackage in this repo (the only package isplugin/) and no YAML ships inside it, so the entry matched nothing. Its[tool.setuptools]table held nothing else, so both go.Verified by building the wheel before and after: identical contents, all 5
plugin/files present in each, so setuptools auto-discovery covers what the explicit table was not doing.🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
🧹 Removes obsolete setuptools package-data configuration from the project metadata.
📊 Key Changes
[tool.setuptools]configuration block frompyproject.toml.samplepackage.plugin.__version__unchanged.🎯 Purpose & Impact