Skip to content

Remove dead setuptools package-data entry - #208

Merged
glenn-jocher merged 1 commit into
mainfrom
pass2-pyproject
Aug 2, 2026
Merged

Remove dead setuptools package-data entry#208
glenn-jocher merged 1 commit into
mainfrom
pass2-pyproject

Conversation

@glenn-jocher

@glenn-jocher glenn-jocher commented Aug 2, 2026

Copy link
Copy Markdown
Member

pyproject.toml carried package-data = { "sample" = ["*.yaml"] } from the Ultralytics Python template. There is no sample package in this repo (the only package is plugin/) and no YAML ships inside it, so the entry matched nothing. Its [tool.setuptools] table held nothing else, so both go.

Verified by building the wheel before and after: identical contents, all 5 plugin/ files present in each, so setuptools auto-discovery covers what the explicit table was not doing.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

🧹 Removes obsolete setuptools package-data configuration from the project metadata.

📊 Key Changes

  • Deleted the [tool.setuptools] configuration block from pyproject.toml.
  • Removed the unused package-data declaration for YAML files in the sample package.
  • Kept dynamic version loading from plugin.__version__ unchanged.

🎯 Purpose & Impact

  • Simplifies the project configuration and removes unnecessary packaging metadata.
  • Reduces the risk of maintaining stale or irrelevant package-data settings.
  • Has minimal user-facing impact, with no expected changes to the plugin’s runtime behavior.

@UltralyticsAssistant UltralyticsAssistant added the fixed Bug has been resolved label Aug 2, 2026
@UltralyticsAssistant

Copy link
Copy Markdown
Member

👋 Hello @glenn-jocher, thank you for submitting a ultralytics/mkdocs 🚀 PR! To ensure a seamless integration of your work, please review the following checklist:

  • Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • Synchronize with Source: Confirm your PR is synchronized with the ultralytics/mkdocs main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • Update Documentation: Update the relevant documentation for any new or modified features.
  • Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀

🤖 This is an automated message; an engineer will assist with the review.

@UltralyticsAssistant UltralyticsAssistant left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 PR Review

Made with ❤️ by Ultralytics Actions

Clean change. The removed setuptools package-data rule references no repository content, while the remaining configuration still uses setuptools with automatic package discovery and dynamic version loading from plugin.__version__.

@glenn-jocher
glenn-jocher merged commit e342a69 into main Aug 2, 2026
5 checks passed
@glenn-jocher
glenn-jocher deleted the pass2-pyproject branch August 2, 2026 19:01
@UltralyticsAssistant

Copy link
Copy Markdown
Member

🎉 Thank you, @glenn-jocher, for merging this PR!

As Leonardo da Vinci said, “Simplicity is the ultimate sophistication.” Removing obsolete setuptools metadata keeps the project configuration cleaner, reduces maintenance overhead, and preserves the plugin’s existing behavior. We appreciate your contribution to keeping the codebase focused and reliable!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fixed Bug has been resolved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants