fix: suppress pnpm status output in setup-playwright version check#56
Merged
Conversation
…ersion check pnpm 11 prints a deps-status header to stdout before running the binary: 'Already up to date\nDone in 47ms using pnpm v11.1.3' The version regex matched '11.1.3' from that header, making the action think playwright was installed when it was not, then failing on the browser install step. --silent suppresses pnpm's own output so only the playwright binary's output is captured.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In pnpm 11,
pnpm exec playwright --versionprints a deps-status header to stdout before running the binary:The version regex
[0-9]+(\.[0-9]+)+matched11.1.3(the pnpm version), causing the action to believe playwright was installed in projects where it isn't. The subsequent browser install step then failed with:Fix
Add
--silentto suppress pnpm's own output, so only the playwright binary's output reaches the grep.Test plan