warn when add_encoders is set but fit_from_dataset() is called#3134
Closed
DresdenGman wants to merge 1 commit into
Closed
warn when add_encoders is set but fit_from_dataset() is called#3134DresdenGman wants to merge 1 commit into
DresdenGman wants to merge 1 commit into
Conversation
Collaborator
|
@DresdenGman not sure what you were committing, but the diffs look fishy. Also, we're already working on this in #3086. Closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the silent behavior described in #3006.
When a model is created with add_encoders and fit_from_dataset() is called instead of fit(), the encoders are quietly ignored with no indication that encoded covariates won't be included in training.
Added a logger.warning that fires when self.add_encoders is set, and a note in the docstring so it's visible in the API docs too. No behavior changes beyond the new warning.
Closes #3006