Detect XML structured suffix response types - #616
Open
deepakganesh78 wants to merge 1 commit into
Open
Conversation
Treat RSS, Atom, XHTML, SVG, and other +xml media types as text while preserving JSON, event stream, and binary detection. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough
ChangesXML response detection
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #597.
detectResponseTypeonly recognized a small set of exact XML media types. Structured syntax suffix types such asapplication/rss+xml,application/atom+xml,application/xhtml+xml, andimage/svg+xmltherefore fell through toblobinstead of being decoded as text.This adds XML media-type detection for
application/*+xmlandimage/*+xml, while retaining the existingtext/*handling. Tests cover RSS, Atom, XHTML, SVG, SOAP with parameters, case-insensitive headers, and regression guards for JSON, SSE, and binary content.Validation:
vitest run --coverage— 35 passed before final edge-case additionsvitest run test/index.test.ts— 37 passedThe repository-wide Prettier command reports pre-existing formatting differences in 16 untouched files on this Windows checkout; all changed files pass the same checks.
Summary by CodeRabbit
Bug Fixes
Tests