jets: avoid reallocation in aes-cbc#1024
Merged
Merged
Conversation
pkova
added a commit
that referenced
this pull request
Jul 10, 2026
This PR updates the u3 realloc functions to require explicit old sizes, making it much easier to add alternative bump/arena allocator implementations. It builds on #1024 and includes a merge of #1025 to accomplish (these should be merged first). It also vendors and modifies the pdjson library used in the `+de:json` jet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses the unsafe aes-cbc interface from urbit/urcrypt#22 avoid reallocating buffers for padding (and further reducing allocations with the slab api). It also fixes a jet mismatch in the handling of empty messages (by setting the minimum
bloq=7length of the input to1). The appropriate test cases are in urbit/urbit#7357