fix(compose): anchor bind-mount sources to --project-directory#65
Merged
Conversation
us
force-pushed
the
fix/compose-bindmount-project-directory
branch
from
July 4, 2026 11:20
d594887 to
5b07ba5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ComposeOrchestrator.resolveVolumeMountsresolved relative bind-mount sources (./data,../shared,data/dir) against the process's current working directory instead of the Compose project directory (--project-directory), even thoughstartServicealready threadsprojectDirthrough for build-context resolution.projectDir: URLparameter toresolveVolumeMountsand anchor relative sources to it, mirroring the existingImageManager.resolveContextPath(context:cwd:)pattern used for build contexts.~-prefixed sources are now expanded independently viaexpandingTildeInPathrather than relying onURL(fileURLWithPath:)'s implicit CWD-relative tilde expansion, keeping their resolution decoupled from the project directory.Closes #60
Test plan
swift buildswift test --filter ComposeOrchestratorTests(18/18 passed, including 2 new tests proving relative bind-mount sources anchor to a project directory that differs from CWD)swift test(full suite, 304/304 passed)