Fix generate-schema format diagnostics - #428
Open
mcc0nnell wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align
generate-schema --ashelp and invalid-format diagnostics withISchemaGenerator.SchemaFormat(JSONandXMLonly). YAML is no longeradvertised as a valid generated-schema format.
All Submissions:
Fork Actions failed before compile:
gov.nist.secauto:oss-parent:pom:28-SNAPSHOTis absent from oss.sonatype.org (pre-existing ondevelop). Local validation of this change passed.Changes to Core Features:
What
Align
generate-schema --ashelp and invalid-value diagnostics with theformats actually supported by
ISchemaGenerator.SchemaFormat.Why
SchemaFormatcurrently supports only JSON and XML, but the error pathenumerates the broader databind
Formatenum and therefore advertises YAML.The option help also describes
--asas a source format and lists YAML.Changes
--asas the generated schema formatSchemaFormat.values()Validation
mvn -B -pl metaschema-cli -am -Dtest=GenerateSchemaCommandTest -Dsurefire.failIfNoSpecifiedTests=false test
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0
BUILD SUCCESS
mvn -B -pl metaschema-cli -am -Prelease verify -Dtest=GenerateSchemaCommandTest -Dsurefire.failIfNoSpecifiedTests=false
Checkstyle: 0 violations
SpotBugs: 0
GenerateSchemaCommandTest: 2/2 passed
BUILD SUCCESS
Fixes #