Security: gate X-Forwarded-For behind trusted proxies with strict IP#2049
Open
ciphershade7 wants to merge 1 commit into
Open
Security: gate X-Forwarded-For behind trusted proxies with strict IP#2049ciphershade7 wants to merge 1 commit into
ciphershade7 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a security vulnerability where ScanRateLimiter unconditionally trusted the first IP in the X-Forwarded-For header allowing an attacker to spoof it to bypass rate limits or purposefully get innocent victim IPs blocked.
The update:
Issue
#1757
Type of Change
How Has This Been Tested?
Ran the targeted rate limiter test suite via "pytest testing/backend/test_rate_limiter.py -v"
tests added to verify the fix:
Checklist