Skip to content

mkfifo: drop path-based chmod to close TOCTOU race (#10020)#12174

Merged
sylvestre merged 1 commit into
uutils:mainfrom
sylvestre:toctou-mkfifo
Jun 5, 2026
Merged

mkfifo: drop path-based chmod to close TOCTOU race (#10020)#12174
sylvestre merged 1 commit into
uutils:mainfrom
sylvestre:toctou-mkfifo

Conversation

@sylvestre

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Congrats! The gnu test tests/cut/cut-huge-range is now passing!
Note: The gnu test tests/misc/write-errors was skipped on 'main' but is now failing.
Skip an intermittent issue tests/tail/tail-n0f (was skipped on 'main', now failing)

@sylvestre sylvestre force-pushed the toctou-mkfifo branch 2 times, most recently from 170ed83 to 2fc1822 Compare May 7, 2026 06:50
@sylvestre sylvestre requested review from RenjiSann and cakebaker May 7, 2026 06:54
@sylvestre sylvestre marked this pull request as ready for review May 7, 2026 06:54
@codspeed-hq

codspeed-hq Bot commented May 7, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 323 untouched benchmarks
⏩ 46 skipped benchmarks1


Comparing sylvestre:toctou-mkfifo (f5cb691) with main (4353689)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@RenjiSann

Copy link
Copy Markdown
Collaborator

Ci is sad :/

@RenjiSann

Copy link
Copy Markdown
Collaborator

There are still some CI fails, looks like missing spell ignore

@sylvestre sylvestre merged commit c004672 into uutils:main Jun 5, 2026
177 checks passed
@sylvestre sylvestre deleted the toctou-mkfifo branch June 5, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants