head: add TOCTOU regression tests and fix comment typo#12637
Merged
Conversation
Follow-up to the metadata TOCTOU fix (uutils#11972, PR uutils#12439): - Add a syscall-level regression guard in util/check-safe-traversal.sh: under strace, head must read metadata from the open descriptor (fstat/statx on the fd) and must not stat the path before opening it. Verified this fails on the pre-fix code and passes after. - Add an integration test asserting that an unreadable file produces an error but no "==> name <==" header, matching GNU (the header is only printed after a successful open). - Fix a stray paren in the Windows-branch comment.
|
GNU testsuite comparison: |
Contributor
|
Thanks Sylvestre! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.