Skip to content

wc: drop guard for non FIFO stream#12736

Open
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:wc-stream
Open

wc: drop guard for non FIFO stream#12736
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:wc-stream

Conversation

@oech3

@oech3 oech3 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor
  • simplify code for stream input
  • reduce usage of libc
  • splice non-FIFO streams

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/tail/retry (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tty-eof (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/seq/seq-epipe is now being skipped but was previously passing.

@oech3 oech3 marked this pull request as ready for review June 9, 2026 07:13
@codspeed-hq

codspeed-hq Bot commented Jun 10, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 2 improved benchmarks
❌ 1 regressed benchmark
✅ 320 untouched benchmarks
⏩ 46 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory cp_recursive_deep_tree[(120, 4)] 562.5 KB 615.6 KB -8.62%
Simulation ls_recursive_balanced_tree[(6, 4, 15)] 52.3 ms 49.6 ms +5.51%
Simulation ls_recursive_wide_tree[(10000, 1000)] 34.3 ms 33 ms +3.99%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing oech3:wc-stream (ca5dc95) with main (4223537)

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant