Skip to content

chmod: modified no-op errors for parity with gnu #12748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
max-amb wants to merge 4 commits into
base: main
Choose a base branch
from
+10 −7
Open

chmod: modified no-op errors for parity with gnu #12748

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0220e83
chmod: modified errors for parity with gnu
max-amb Jun 10, 2026
bb42596
Added clarification for modification
max-amb Jun 10, 2026
85338d7
Merge branch 'main' into chmod_no_op
max-amb Jun 10, 2026
9105442
Merge branch 'main' into chmod_no_op
max-amb Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/uu/chmod/src/chmod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ use std::os::unix::fs::{MetadataExt, PermissionsExt};
use std::path::{Path, PathBuf};
use thiserror::Error;
use uucore::display::Quotable;
use uucore::error::{ExitCode, UError, UResult, USimpleError, UUsageError, set_exit_code};
use uucore::error::{
ExitCode, UError, UResult, USimpleError, UUsageError, set_exit_code, strip_errno,
};
use uucore::fs::{FileInformation, display_permissions_unix};
use uucore::mode;
use uucore::perms::{TraverseSymlinks, configure_symlink_and_recursion};
Expand Down Expand Up @@ -772,13 +774,14 @@ impl Chmoder {
}

fn change_file(&self, fperm: u32, mode: u32, file: &Path) -> Result<(), i32> {
if fperm == mode {
// Use the helper method for consistent reporting
self.report_permission_change(file, fperm, mode);
Ok(())
} else if let Err(err) = fs::set_permissions(file, fs::Permissions::from_mode(mode)) {
// fs::set_permissions calls chmod which we need for the gnu test chmod/only-op.sh
if let Err(err) = fs::set_permissions(file, fs::Permissions::from_mode(mode)) {
if !self.quiet {
show_error!("{err}");
show_error!(
"changing permissions of {}: {}",
file.quote(),
strip_errno(&err)
);
}
if self.verbose {
println!(
Expand Down
Loading